Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#94 mypage route connect #100

Merged
merged 5 commits into from
Jul 17, 2024
Merged

Feature/#94 mypage route connect #100

merged 5 commits into from
Jul 17, 2024

Conversation

nagaeng
Copy link
Contributor

@nagaeng nagaeng commented Jul 17, 2024

๐Ÿ“Œ PR ์š”์•ฝ

๐ŸŒฑ ์ž‘์—…ํ•œ ๋‚ด์šฉ

  • follower/following screen navi connecting
  • record, bookmark screen -> video detail screen navi connecting

๐ŸŒฑ PR ํฌ์ธํŠธ

  • ์ƒ๋Œ€๋ทฐ, ํ™ˆ ๋“ฑ detail video๋กœ ์—ฐ๊ฒฐ๋ผ์•ผ ํ•˜๋Š” navi ๋‹ค ์‚ฌ์šฉ ๊ฐ€๋Šฅ .... enum class์— ์ƒ์ˆ˜ ์„ ์–ธํ•ด์„œ ๋ฃจํŠธ๋งŒ ๋ณ€๊ฒฝํ•ด์ฃผ๋ฉด ๋‹ค ๊ฐ€๋Šฅ .... ์œ ์šฉํ•˜๊ฒŒ ์‚ฌ์šฉํ•˜์‹œ์š” ......

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท

navi.connecting.mp4

๐Ÿ“ฎ ๊ด€๋ จ ์ด์Šˆ

@nagaeng nagaeng added ๊ธฐ๋Šฅ๊ตฌํ˜„ Skrr ๋‚˜๊ฒฝ ๐Ÿชผ๐Ÿน ๋ ˆ์ฝ”๋”” ๊ฐ“๊ธฐ ๋‚˜๊ฐฑ์ด๊บผ labels Jul 17, 2024
@nagaeng nagaeng self-assigned this Jul 17, 2024
nagaeng added 3 commits July 17, 2024 20:44
@nagaeng
Merge branch 'develop' of https://github.com/Team-Recordy/Recordy-Andโ€ฆ
a65386f 
โ€ฆroid into feature/#94-mypage-route-connect

# Conflicts:
#	feature/navigator/src/main/java/com/record/navigator/MainNavigator.kt
#	feature/video/src/main/java/com/record/video/navigation/VideoNavigation.kt
@nagaeng
[refactor] #94 navigateVideoDetail ์ธ์ž ์ˆ˜์ •์— ๋”ฐ๋ฅธ ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง
bb09456
@nagaeng
[chore] #94 ktlint
677a1fb
Sangwook123
Sangwook123 approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@Sangwook123 Sangwook123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100๋ฒˆ์งธ ์ถ•ํ•˜ํ•ฉ๋‹ˆ๋‹ค

@nagaeng nagaeng merged commit 9293c19 into develop Jul 17, 2024
1 check passed
@nagaeng nagaeng deleted the feature/#94-mypage-route-connect branch July 18, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sangwook123 Sangwook123 Sangwook123 approved these changes

@cacaocoffee cacaocoffee Awaiting requested review from cacaocoffee

@lsakee lsakee Awaiting requested review from lsakee

@seohee0925 seohee0925 Awaiting requested review from seohee0925

Assignees

@nagaeng nagaeng

Labels
๊ธฐ๋Šฅ๊ตฌํ˜„ Skrr ๋‚˜๊ฒฝ ๐Ÿชผ๐Ÿน ๋ ˆ์ฝ”๋”” ๊ฐ“๊ธฐ ๋‚˜๊ฐฑ์ด๊บผ
Projects
None yet
Milestone
UI ์ž‘์—… ๋ฐ ๊ธฐ๋Šฅ ๊ตฌํ˜„
Development

Successfully merging this pull request may close these issues.

[feat] mypage page route connecting
2 participants
@nagaeng @Sangwook123